Asset Modules: Introduce session manager with one id per download request - #3757
Open
EDWARD-012 wants to merge 1 commit into
Open
Asset Modules: Introduce session manager with one id per download request#3757EDWARD-012 wants to merge 1 commit into
EDWARD-012 wants to merge 1 commit into
Conversation
…uest Each startDownload allocates one ever-increasing global session id that covers all requested modules, matching Play-like PAD session semantics for microg#2675.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a Play-like asset module session manager for #2675 (follow-up to #2506).
Each
startDownloadallocates one ever-increasing global session id that covers all requested modules. Replaces per-modulebase + moduleIndexassignment.requestDownloadInfodoes not allocate sessions.Changes
AssetModuleSessionManager(SharedPreferencesAssetModuleSessionIdGenerator/Latest)sessionId(keepsessionIdsmap with identical values)onStartDownloadto pass the real session id; pack-scopedsession_idis never statusgetSessionStatesreturns one bundle per sessionOut of scope
Test plan
:vending-app:assembleDefaultDebug/lintDefaultDebugFixes #2675